weizhouapache commented on code in PR #10543:
URL: https://github.com/apache/cloudstack/pull/10543#discussion_r2004170450
##########
engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql:
##########
@@ -19,6 +19,9 @@
-- Schema upgrade from 4.20.0.0 to 4.20.1.0
--;
+-- Delete user vm details for guest CPU mode/model which are root admin only
+DELETE FROM `cloud`.`user_vm_details` WHERE `name` IN
('guest.cpu.mode','guest.cpu.model');
Review Comment:
These two settings have no impact in older versions, but are only available
for root admin with this PR (because I think the host CPU is sensitive
information).
I think it is better to remove them during upgrade. Otherwise user can add
the settings before upgrade, and get the Host CPU after upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
