weizhouapache commented on code in PR #10595:
URL: https://github.com/apache/cloudstack/pull/10595#discussion_r2007432614
##########
ui/src/views/network/VpcTiersTab.vue:
##########
@@ -553,9 +553,9 @@ export default {
if (this.publicLBExists && (idx === -1 ||
this.lbProviderMap.publicLb.vpc.indexOf(offering.service.map(svc => { return
svc.provider[0].name })[idx]) === -1)) {
filteredOfferings.push(offering)
} else if (!this.publicLBExists && vpcLbServiceIndex > -1) {
- const vpcLbServiceProvider = vpcLbServiceIndex === -1 ? undefined
: this.resource.service[vpcLbServiceIndex].provider[0].name
+ const vpcLbServiceProviders = vpcLbServiceIndex === -1 ? undefined
: this.resource.service[vpcLbServiceIndex].provider.map(provider =>
provider.name)
Review Comment:
a short explanation:
- the service has two providers: InternalLbVm and VpcVirtualRouter
- without this PR, the network offerings are listed only if (1) no LB; (2)
provider is InternalLbVm
- with this PR, the network offerings are listed only if (1) no LB; (2)
provider is InternalLbVm; (3) provider is VpcVirtualRouter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
