DaanHoogland commented on code in PR #10140: URL: https://github.com/apache/cloudstack/pull/10140#discussion_r2037010182
########## plugins/backup/dummy/src/main/java/org/apache/cloudstack/backup/DummyBackupProvider.java: ########## @@ -35,12 +37,14 @@ import com.cloud.vm.VirtualMachine; public class DummyBackupProvider extends AdapterBase implements BackupProvider { - + private static final Logger LOG = LogManager.getLogger(DummyBackupProvider.class); Review Comment: naming convention says `private static final` means all capitals, @weizhouapache . I think this is ok, unless we remove the `static` part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org