weizhouapache commented on code in PR #10140:
URL: https://github.com/apache/cloudstack/pull/10140#discussion_r2036998792
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/storage/AddObjectStoragePoolCmd.java:
##########
@@ -56,6 +56,9 @@ public class AddObjectStoragePoolCmd extends BaseCmd {
@Parameter(name = ApiConstants.TAGS, type = CommandType.STRING,
description = "the tags for the storage pool")
private String tags;
+ @Parameter(name = ApiConstants.SIZE, type = CommandType.LONG, description
= "the total size of the object store in GiB. Used for tracking capacity and
sending alerts", since = "4.21")
Review Comment:
got it, thanks @abh1sar
##########
api/src/main/java/com/cloud/vm/VirtualMachine.java:
##########
@@ -128,7 +128,6 @@ public static StateMachine2<State, VirtualMachine.Event,
VirtualMachine> getStat
s_fsm.addTransition(new Transition<State, Event>(State.Error,
VirtualMachine.Event.DestroyRequested, State.Expunging, null));
s_fsm.addTransition(new Transition<State, Event>(State.Error,
VirtualMachine.Event.ExpungeOperation, State.Expunging, null));
s_fsm.addTransition(new Transition<State, Event>(State.Stopped,
Event.RestoringRequested, State.Restoring, null));
- s_fsm.addTransition(new Transition<State, Event>(State.Expunging,
Event.RestoringRequested, State.Restoring, null));
Review Comment:
ok, got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
