winterhazel opened a new pull request, #10712: URL: https://github.com/apache/cloudstack/pull/10712
### Description This PR backports #9888 to 4.19, fixing the issue described in #10687 and some other ones. - Duplicated entries in the networks helper table, resulting in duplicated usage record generation; - Port forwarding helper entries are never removed, resulting in removed port forwarding rules generating usage records; - Load balancer helper entries are never removed, resulting in removed load balancer rules generating usage records; - VM snapshot helper entries are never removed, resulting in removed VM snapshots generating usage records; - Helper entries for volumes in the secondary storage are never removed after the volume gets attached to a VM, resulting in secondary storage usage records being generated for volumes that are not in the secondary storage anymore. I still intend to work on a normalization script before closing #10687, but it can be merged separately from this PR. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [ ] BLOCKER - [ ] Critical - [X] Major - [ ] Minor - [ ] Trivial ### How Has This Been Tested? I reproduced the tests described in #9888. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org