winterhazel commented on PR #10712: URL: https://github.com/apache/cloudstack/pull/10712#issuecomment-2846126525
> @winterhazel do we need more work on this? I think we discussed extra work on other issues/PRs @DaanHoogland this should be ready now. I made some adjustments here based on the previous discussions: - when processing a duplicated `NETWORK.CREATE`, ignore it. Previously, we were marking the existing helper entry as removed and creating a new one - when processing a `NETWORK,UPDATE`, mark the previous entry as removed and create a new one with the updated information. Previously, the existing entry would have its information overridden, which would result in incorrect usage records (the usage records generated for the period before the network was updated would contain the updated information instead of the real information for that period) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
