deajan opened a new pull request, #10723: URL: https://github.com/apache/cloudstack/pull/10723
### Description This PR adds logging to the `keystore-setup` script, and fixes the regex to check old cloudstack-agent password. When adding KVM hosts, the `keystore-setup` script may fail with `530: Failed to setup keystore on the KVM host). On the KVM host` for various reasons (absence of keystore, malformatted agent.properties file, missing permissions...). This adds logs to almost all actions, and also fixes the regex that gets the password from `agent.properties` in order to not fetch commented-out passwords. Fixes #10703 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [X] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? Script has been tested on two AlmaLinux 9.5 KVM hosts with a Cloudstack 4.20 management server. Script has also been submitted to Shellcheck. #### How did you try to break this feature and the system with this change? Re-ran the tests on multiple hosts to validate that the script works ;) Log function from the script has been tested on both RHEL and Debian systems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
