DaanHoogland commented on code in PR #10723:
URL: https://github.com/apache/cloudstack/pull/10723#discussion_r2044525834
##########
scripts/util/keystore-setup:
##########
@@ -22,55 +22,78 @@ KS_PASS="$3"
KS_VALIDITY="$4"
CSR_FILE="$5"
+LOG_FILE="/var/log/cloudstack/agent/keystore-setup.log"
+
ALIAS="cloud"
LIBVIRTD_FILE="/etc/libvirt/libvirtd.conf"
+log() {
Review Comment:
I am not sure if it installed by default on your host's OS, but there is a
tool called logger to do this, no need for a script function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
