winterhazel commented on code in PR #10721:
URL: https://github.com/apache/cloudstack/pull/10721#discussion_r2045244382
##########
usage/src/main/java/com/cloud/usage/parser/NetworkOfferingUsageParser.java:
##########
@@ -155,9 +154,8 @@ private static void createUsageRecord(int type, long
runningTime, Date startDate
// Create the usage record
String usageDesc = "Network offering:" + noId + " for Vm : " + vmId +
" usage time";
- long defaultNic = (isDefault) ? 1 : 0;
UsageVO usageRecord =
- new UsageVO(zoneId, account.getId(), account.getDomainId(),
usageDesc, usageDisplay + " Hrs", type, new Double(usage), vmId, null, noId,
null, defaultNic,
+ new UsageVO(zoneId, account.getId(), account.getDomainId(),
usageDesc, usageDisplay + " Hrs", type, new Double(usage), vmId, null, noId,
null, noId,
Review Comment:
This change does not make sense for me. Why are we including the network
offering's ID in `usage_id` when the ID is already in `offering_id`? I think we
should leave it as it is.
I know that the naming does not make much sense, but this field represents
whether the NIC associated with the helper entry is a VM's default one. With
this change, we do not have that information anymore, possibly breaking
integrations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
