DaanHoogland commented on code in PR #10721:
URL: https://github.com/apache/cloudstack/pull/10721#discussion_r2048457113
##########
usage/src/main/java/com/cloud/usage/parser/NetworkOfferingUsageParser.java:
##########
@@ -155,9 +154,8 @@ private static void createUsageRecord(int type, long
runningTime, Date startDate
// Create the usage record
String usageDesc = "Network offering:" + noId + " for Vm : " + vmId +
" usage time";
- long defaultNic = (isDefault) ? 1 : 0;
UsageVO usageRecord =
- new UsageVO(zoneId, account.getId(), account.getDomainId(),
usageDesc, usageDisplay + " Hrs", type, new Double(usage), vmId, null, noId,
null, defaultNic,
+ new UsageVO(zoneId, account.getId(), account.getDomainId(),
usageDesc, usageDisplay + " Hrs", type, new Double(usage), vmId, null, noId,
null, noId,
Review Comment:
clear,
let’ s indeed think about deprecating it than.
@sudo87 , do you understand @winterhazel ‘ s argument? (and sorry about your
PR ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
