hsato03 commented on PR #8942: URL: https://github.com/apache/cloudstack/pull/8942#issuecomment-2811661341
I have done the following tests and the feature seems to be working fine. #### 1. createGuiTheme API | N° | Test case | Result | Expected result? (Y/N) | | -- | ------------- | ------------- | ------------------------- | | 1 | Create a theme using only the `css` parameter | The CSS was correctly applied | Y | | 2 | Create a theme by importing a CSS file using the `css` parameter | The CSS was correctly applied | Y | | 3 | Create a theme using only the `json configuration` parameter | The json configuration was loaded correctly | Y | | 4 | Create a theme using the `css` and `json configuration` parameters | Both CSS and json configuration were correctly applied | Y | | 5 | Create a public theme | The theme has been applied to all users | Y | | 6 | Create more than one public theme | An error occurred indicating that there should only be one public theme | Y | | 7 | Create a theme for specific domains using the `recursivedomains` parameter as `false`, overriding the public theme | The theme has been applied to users belonging to the specified domains and the public theme has been applied to other users not associated with a theme | Y | | 8 | Create a theme for specific domains using the `recursivedomains` parameter as `true`, overriding the public theme | The theme has been applied to users belonging to the specified domains and their subdomains; the public theme has been applied to other users not associated with a theme | Y | | 9 | Create a theme for specific accounts, overriding the public theme | The theme has been applied to users of the specified accounts and the public theme has been applied to other users not associated with a theme | Y | | 10 | Create a theme for a specific Common Name, overriding the public theme | The theme has been applied to the specified CN and the public theme has been applied to other domain names not associated with a theme | Y | | 11 | Create a theme for a specific Common Name, domains and accounts using the parameter `recursivedomains` as `false` | The theme has been applied to users of the specified accounts and domains or to users using the specified CN | Y | | 12 | Create a theme for specific Common Name, domains and accounts using the parameter `recursivedomains` as `true` | The theme has been applied to users of the specified accounts and domains and their subdomains, or to users using the specified CN | Y | #### 2. updateGuiTheme API | N° | Test case | Result | Expected result? (Y/N) | | -- | ------------- | ------------- | ------------------------- | | 1 | Update a theme using the `CSS`, `json configuration`, `description`, `domainids`, `accountids`, `commonnames` and `recursivedomains` parameters | All fields have been updated correctly | Y | | 2 | Update a non-public theme using the `ispublic` parameter as `true` when there is no public theme | The theme became public and has been applied to all users | Y | | 3 | Update a non-public theme using the `ispublic` parameter as `true` when a public theme already exists | An error occurred indicating that there should only be one public theme | Y | | 4 | Update a public theme using the `domainids` parameter and the `recursivedomains` parameter as `false` | The theme became non-public and has been applied only to users belonging to the specified domains | Y | | 5 | Update a public theme using the `domainids` parameter and the `recursivedomains` parameter as `true` | The theme became non-public and has been applied only to users belonging to the specified domains and their subdomains | Y | | 6 | Update a public theme using the `accountids` parameter | The theme became non-public and has been applied only to users of the specified accounts | Y | | 7 | Update a public theme using the `commonnames` parameter | The theme remained public and has been applied only to the specified CN | Y | #### 3. listGuiThemes API I tested listing the themes using different combinations of parameters and they all had the expected result. #### 4. removeGuiTheme API The API is removing themes correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
