DaanHoogland commented on code in PR #10704:
URL: https://github.com/apache/cloudstack/pull/10704#discussion_r2048589314
##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1635,10 +1635,19 @@ public Network createGuestNetwork(CreateNetworkCmd cmd)
throws InsufficientCapac
throwInvalidIdException("Network offering with specified id
doesn't support adding multiple ip ranges", ntwkOff.getUuid(),
NETWORK_OFFERING_ID);
}
- if (GuestType.Shared == ntwkOff.getGuestType() &&
!ntwkOff.isSpecifyVlan() && Objects.isNull(associatedNetworkId)) {
- throw new CloudRuntimeException("Associated network must be
provided when creating Shared networks when specifyVlan is false");
- }
+
+ if (GuestType.Shared == ntwkOff.getGuestType()) {
+ if (!ntwkOff.isSpecifyIpRanges()) {
+ throw new CloudRuntimeException("The 'specifyipranges'
parameter should be true for Shared Networks");
+ }
+ if (ipv4 && Objects.isNull(startIP)) {
+ throw new CloudRuntimeException("IPv4 address range needs to
be provided");
+ }
+ if (ipv6 && Objects.isNull(startIPv6)) {
+ throw new CloudRuntimeException("IPv6 address range needs to
be provided");
+ }
Review Comment:
ok, so in spite of this workaround (no high priority) we don’ t even need
the UI elements for ipv6 , you are saying @wido ? (cc @weizhouapache )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
