Re: [PR] Don't specify ipv6 ranges for shared network [cloudstack]

Thu, 17 Apr 2025 08:17:32 -0700 


weizhouapache commented on code in PR #10746:
URL: https://github.com/apache/cloudstack/pull/10746#discussion_r2049158007


##########
server/src/main/java/com/cloud/network/NetworkServiceImpl.java:
##########
@@ -1644,9 +1644,7 @@ public Network createGuestNetwork(CreateNetworkCmd cmd) 
throws InsufficientCapac
             if (ipv4 && Objects.isNull(startIP)) {
                 throw new CloudRuntimeException("IPv4 address range needs to 
be provided");
             }
-            if (ipv6 && Objects.isNull(startIPv6)) {
-                throw new CloudRuntimeException("IPv6 address range needs to 
be provided");
-            }
+            // if (ipv6) ignore entries

Review Comment:
   I do not know what is the best word to describe it ....
   
   the behaviour is 
   
   - if ipv6 range is passed, it is saved in database
   
![image](https://github.com/user-attachments/assets/be8949dd-0deb-457d-bdff-dcfc98c6e389)
   
   - but vm gets a IP out of the ipv6 range
   
![image](https://github.com/user-attachments/assets/aee1271f-1ea8-4ef6-b1e5-b40a5209bfa4)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to