sureshanaparti commented on code in PR #10774:
URL: https://github.com/apache/cloudstack/pull/10774#discussion_r2059611507


##########
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java:
##########
@@ -810,7 +811,7 @@ public Answer createVolume(final CreateObjectCommand cmd) {
             final SR poolSr = hypervisorResource.getStorageRepository(conn,
                     CitrixHelper.getSRNameLabel(primaryStore.getUuid(), 
primaryStore.getPoolType(), primaryStore.getPath()));
             VDI.Record vdir = new VDI.Record();
-            vdir.nameLabel = volume.getName();
+            vdir.nameLabel = getEncodedVolumeName(volume.getName());

Review Comment:
   @Pearl1594 can you check if this change is needed here as well (while 
creating volume from snapshot) =>
   
   
https://github.com/apache/cloudstack/blob/603cd84b49428c08fae50470c8c69a66468b53fe/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/XenServerStorageProcessor.java#L510-L517



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to