nvazquez commented on code in PR #10776:
URL: https://github.com/apache/cloudstack/pull/10776#discussion_r2059915953
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -3556,7 +3556,9 @@ public void reallyRun() {
final List<Long> networkIds =
_networksDao.findNetworksToGarbageCollect();
final int netGcWait =
NumbersUtil.parseInt(_configDao.getValue(NetworkGcWait.key()), 60);
- logger.info("NetworkGarbageCollector uses '{}' seconds for GC
interval.", netGcWait);
+ final int netGcInterval =
NumbersUtil.parseInt(_configDao.getValue(NetworkGcInterval.key()), 60);
+ logger.info("NetworkGarbageCollector uses '{}' seconds for GC
wait.", netGcWait);
+ logger.info("NetworkGarbageCollector uses '{}' seconds for GC
interval.", netGcInterval);
Review Comment:
Perhaps these 2 lines can be unified into a single one:
`NetworkGarbageCollector uses '{}' seconds for GC wait and '{}' seconds for GC
interval`.
##########
engine/schema/src/main/resources/META-INF/db/schema-42000to42010.sql:
##########
@@ -69,3 +69,8 @@ CALL `cloud`.`IDEMPOTENT_UPDATE_API_PERMISSION`('Read-Only
Admin - Default', 'va
CALL `cloud`.`IDEMPOTENT_UPDATE_API_PERMISSION`('Support Admin - Default',
'setupUserTwoFactorAuthentication', 'ALLOW');
CALL `cloud`.`IDEMPOTENT_UPDATE_API_PERMISSION`('Support Admin - Default',
'validateUserTwoFactorAuthenticationCode', 'ALLOW');
+
+-- Fix dynamic setting for the network.gc.interval
+
+UPDATE `cloud`.`configuration` SET `is_dynamic`=0 WHERE
`name`='network.gc.interval';
+
Review Comment:
+1, no need for this SQL change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
