weizhouapache commented on code in PR #10776:
URL: https://github.com/apache/cloudstack/pull/10776#discussion_r2097473703
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -3556,7 +3556,8 @@ public void reallyRun() {
final List<Long> networkIds =
_networksDao.findNetworksToGarbageCollect();
final int netGcWait =
NumbersUtil.parseInt(_configDao.getValue(NetworkGcWait.key()), 60);
- logger.info("NetworkGarbageCollector uses '{}' seconds for GC
interval.", netGcWait);
+ final int netGcInterval =
NumbersUtil.parseInt(_configDao.getValue(NetworkGcInterval.key()), 60);
Review Comment:
or even more simple:
```
final int netGcWait = NetworkGcWait.value();
final int netGcInterval = NetworkGcInterval.value();
```
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -4868,7 +4869,7 @@ public String getConfigComponentName() {
public static final ConfigKey<Integer> NetworkGcWait = new
ConfigKey<Integer>(Integer.class, "network.gc.wait", "Advanced", "600",
"Time (in seconds) to wait before shutting down a network that's
not in used", false, Scope.Global, null);
public static final ConfigKey<Integer> NetworkGcInterval = new
ConfigKey<Integer>(Integer.class, "network.gc.interval", "Advanced", "600",
- "Seconds to wait before checking for networks to shutdown", true,
Scope.Global, null);
+ "Seconds to wait before checking for networks to shutdown", false,
Scope.Global, null);
Review Comment:
good :+1:
btw: `NetworkGcWait` can be changed to Dynamic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
