weizhouapache commented on code in PR #10812:
URL: https://github.com/apache/cloudstack/pull/10812#discussion_r2073076372
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -4846,6 +4846,8 @@ protected long getMemoryFreeInKBs(Domain dm) throws
LibvirtException {
}
private boolean canBridgeFirewall(final String prvNic) {
Review Comment:
the method in LibvirtComputingResource are executed on the kvm host (part of
cloudstack-agent)
The host cannot access the database.
so, this won't work.
a feasible way is, adding a setting to agent.properties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
