weizhouapache commented on code in PR #10744:
URL: https://github.com/apache/cloudstack/pull/10744#discussion_r2081543113
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -595,7 +595,7 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
if
(_networkOfferingDao.findByUniqueName(NetworkOffering.DefaultIsolatedNetworkOfferingForVpcNetworks)
== null) {
offering =
_configMgr.createNetworkOffering(NetworkOffering.DefaultIsolatedNetworkOfferingForVpcNetworks,
"Offering for Isolated VPC networks with Source
Nat service enabled", TrafficType.Guest, null, false, Availability.Optional,
null,
- defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, false, null, false, false, null,
false, null, true, true, false, false, null, null, null,true, null, null,
false);
+ defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, true, null, false, false, null, false,
null, true, true, false, false, null, null, null,true, null, null, false);
Review Comment:
checked with Pearl, currently therre is no upgrade path for 4.19.2 to 4.19.3
old envs deployed before 4.19.0 will be good when they upgrade to 4.19.0 or
later
the impacted versions are old envs deployed with 4.19.0/4.19.1/4.19.2
they will be good when upgrade to 4.20.1
but they will have the issue when upgade to 4.19.3, if we do not add upgrade
path with db change
the db change is quite simple ..
we can backport the java change to 4.19.3, so 4.19.3 fresh env will be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
