DaanHoogland commented on code in PR #10744:
URL: https://github.com/apache/cloudstack/pull/10744#discussion_r2081823785
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -595,7 +595,7 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
if
(_networkOfferingDao.findByUniqueName(NetworkOffering.DefaultIsolatedNetworkOfferingForVpcNetworks)
== null) {
offering =
_configMgr.createNetworkOffering(NetworkOffering.DefaultIsolatedNetworkOfferingForVpcNetworks,
"Offering for Isolated VPC networks with Source
Nat service enabled", TrafficType.Guest, null, false, Availability.Optional,
null,
- defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, false, null, false, false, null,
false, null, true, true, false, false, null, null, null,true, null, null,
false);
+ defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, true, null, false, false, null, false,
null, true, true, false, false, null, null, null,true, null, null, false);
Review Comment:
ok, I have a bit of an issue with backporting the sql change, not of
principle but because there is no other reason to create an upgrade path yet. I
think this issue is too low priority to create the upgrade path for the sake of
it. what do you think @Pearl1594 @weizhouapache ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
