harikrishna-patnala commented on code in PR #10381:
URL: https://github.com/apache/cloudstack/pull/10381#discussion_r2085726583
##########
server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java:
##########
@@ -1411,7 +1411,7 @@ private boolean canAvoidCluster(Cluster clusterVO,
ExcludeList avoids, ExcludeLi
if (vmRequiresSharedStorage) {
// check shared pools
- List<StoragePoolVO> allPoolsInCluster =
_storagePoolDao.findPoolsByTags(clusterVO.getDataCenterId(),
clusterVO.getPodId(), clusterVO.getId(), null, false, 0);
+ List<StoragePoolVO> allPoolsInCluster =
_storagePoolDao.findPoolsByTags(clusterVO.getDataCenterId(),
clusterVO.getPodId(), clusterVO.getId(), ScopeType.CLUSTER, null, false, 0);
Review Comment:
I've not changed the logic of the existing method regarding the scope, but I
just generalized the method so that anyone can call this method with any scope.
Previously also the internal method findPoolsByTags() used hardcoded
ScopeType.CLUSTER in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
