sureshanaparti commented on code in PR #10885:
URL: https://github.com/apache/cloudstack/pull/10885#discussion_r2095350974
##########
test/integration/smoke/test_restore_vm.py:
##########
@@ -148,9 +148,13 @@ def
test_03_restore_vm_with_disk_offering_custom_size(self):
self.assertEqual(root_vol.state, 'Ready', "Volume should be in Ready
state")
self.assertEqual(root_vol.size, 16 * 1024 * 1024 * 1024, "Size of
volume and custom disk size should match")
- old_root_vol = Volume.list(self.apiclient, id=old_root_vol.id)[0]
- self.assertEqual(old_root_vol.state, "Destroy", "Old volume should be
in Destroy state")
- Volume.delete(old_root_vol, self.apiclient)
+ if self.hypervisor.lower() == "vmware":
+ old_root_vol = Volume.list(self.apiclient, id=old_root_vol.id)
+ self.assertEqual(old_root_vol, None, "Old volume should be
deleted")
+ else:
+ old_root_vol = Volume.list(self.apiclient, id=old_root_vol.id)[0]
+ self.assertEqual(old_root_vol.state, "Destroy", "Old volume should
be in Destroy state")
+ Volume.delete(old_root_vol, self.apiclient)
Review Comment:
@weizhouapache these changes are required for tests with expunge=True in
restore operation (update test_02_restore_vm_with_disk_offering and
test_01_restore_vm as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
