weizhouapache commented on PR #10880: URL: https://github.com/apache/cloudstack/pull/10880#issuecomment-2891438162
> @weizhouapache so the bug I had found was when using very old images, they would not support bitmaps and the copy process would throw me this error: > ``` > Failed to convert [/mnt/b59eff0f-5b97-37ed-a513-9e1983d1d19b/2784ec51-4776-4b03-9a85-198c465e7d25] to [/mnt/a66f48f5-13c6-3676-b320-a15d32bbf32f/2784ec51-4776-4b03-9a85-198c465e7d25] due to: [qemu-img: Source lacks bitmap support]. org.apache.cloudstack.utils.qemu.QemuImgException: qemu-img: Source lacks bitmap support > ``` > Looking at the Qemu-img source code (see https://github.com/qemu/qemu/blob/master/block/qcow2-bitmap.c#L1767), this error is thrown when the IMG version is lower then 3. So I've added a check to verify it before adding the `--bitmaps` option: [version.txt](https://github.com/user-attachments/files/20299749/version.txt) (I can't upload .patch files due to a github bug apparently) > @JoaoJandre Good finding. Maybe we can merge this PR (if it is still needed ), then you create another PR for your changes ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
