DaanHoogland commented on code in PR #10987:
URL: https://github.com/apache/cloudstack/pull/10987#discussion_r2135873398


##########
systemvm/debian/opt/cloud/bin/configure.py:
##########
@@ -908,6 +908,7 @@ def __createfile(self, ip, folder, file, data):
             if os.path.exists(metamanifest):
                 fh = open(metamanifest, "a+")
                 self.__exflock(fh)
+                fh.seek(0)

Review Comment:
   @GutoVeronezi , I think your intention is
   ```suggestion
                   fh = open(metamanifest, “w+")
                   self.__exflock(fh)
   ```
   opeing with a+ will not truncate the previous version, but only overwrite 
data afaik.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to