DaanHoogland commented on PR #11037: URL: https://github.com/apache/cloudstack/pull/11037#issuecomment-2979075935
@nvazquez , this looks like a good improvement. I wonder if a bigger win can be made (as well). `baseImportInstance` calls two methods based on the cmd Object and both of those get a lot of parameters. In turn they both call `importVirtualMachineInternal` which gets 21 parameters. I imagine most of those come from the cmd object or are directly consequential to the contents of it. If we just keep passing the cmd object, if need be on the basis of an interface, I think we can make that part more legible and in the process more optimal on runtime. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
