DaanHoogland commented on code in PR #11076:
URL: https://github.com/apache/cloudstack/pull/11076#discussion_r2163085132
##########
engine/schema/src/main/java/com/cloud/network/dao/PublicIpQuarantineDaoImpl.java:
##########
@@ -26,15 +26,19 @@
import javax.annotation.PostConstruct;
import javax.inject.Inject;
+import java.util.Date;
+import java.util.List;
@Component
public class PublicIpQuarantineDaoImpl extends
GenericDaoBase<PublicIpQuarantineVO, Long> implements PublicIpQuarantineDao {
private SearchBuilder<PublicIpQuarantineVO> publicIpAddressByIdSearch;
private SearchBuilder<IPAddressVO> ipAddressSearchBuilder;
+ private SearchBuilder<PublicIpQuarantineVO> quarantinedIpAddressesSearch;
+
@Inject
- IPAddressDao ipAddressDao;
+ private IPAddressDao ipAddressDao;
Review Comment:
i’d prefer to keep injected fields as package scope, because it tends to
trigger warnings , “privvate field never assigned”. Strictly speaking these
could be private though. It would be just for preventing the warnings and the
package scope helps in test cases at times as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
