sureshanaparti commented on code in PR #11137:
URL: https://github.com/apache/cloudstack/pull/11137#discussion_r2185195712
##########
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##########
@@ -1431,29 +1432,35 @@ protected void checkRoleEscalation(Account caller,
Account requested) {
requested.getUuid(),
requested.getRoleId()));
}
+ if (caller.getRoleId().equals(requested.getRoleId())) {
+ return;
+ }
List<APIChecker> apiCheckers = getEnabledApiCheckers();
+ for (APIChecker apiChecker : apiCheckers) {
+ checkApiAccess(apiChecker, caller, requested);
+ }
+ }
+
+ private void checkApiAccess(APIChecker apiChecker, Account caller, Account
requested) throws PermissionDeniedException {
+ Pair<Role, List<RolePermission>> roleAndPermissionsForCaller =
apiChecker.getRolePermissions(caller.getRoleId());
+ Pair<Role, List<RolePermission>> roleAndPermissionsForRequest =
apiChecker.getRolePermissions(requested.getRoleId());
Review Comment:
```suggestion
Pair<Role, List<RolePermission>> roleAndPermissionsForRequested =
apiChecker.getRolePermissions(requested.getRoleId());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
