shwstppr commented on PR #11132:
URL: https://github.com/apache/cloudstack/pull/11132#issuecomment-3046069846

   @weizhouapache I'm not entirely sure about these changes (we discussed this 
earlier!?).
   My understanding of the sslverification flag is that when set to true, it 
should enforce certificate validation—i.e., the webhook delivery service should 
validate the server's certificate using the trusted certificates available in 
the JRE.
   
   However, with the current change, it seems we're using a "trust all" 
approach even when sslverification is set to true.
   
   In my understanding, the correct way to test this would be to set up a 
server using self-signed certificates, explicitly add those certificates to the 
trusted store on the management server, and then verify that delivery works as 
expected when sslverification is set to true.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to