Copilot commented on code in PR #11191:
URL: https://github.com/apache/cloudstack/pull/11191#discussion_r2204224583
##########
ui/src/utils/request.js:
##########
@@ -163,6 +165,26 @@ service.interceptors.request.use(config => {
config.params.ignoreproject = null
Review Comment:
Assigning null to `ignoreproject` will send `ignoreproject=null` in the
request, which may not be handled as intended. Consider deleting the
`ignoreproject` property from `config.params` so the parameter is omitted
entirely.
```suggestion
delete config.params.ignoreproject
```
##########
ui/src/utils/request.js:
##########
@@ -163,6 +165,26 @@ service.interceptors.request.use(config => {
config.params.ignoreproject = null
}
}
+
+ // Handle POST requests (data)
Review Comment:
[nitpick] The inlined branching logic for POST-data adjustments is complex.
Extracting it into a helper function and using named constants for commands
(`listTags`, `assignVirtualMachine`) will improve readability and reduce
duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
