shwstppr commented on code in PR #11220:
URL: https://github.com/apache/cloudstack/pull/11220#discussion_r2210228431
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapAuthenticator.java:
##########
@@ -229,23 +235,27 @@ private Pair<Boolean, ActionOnFailedAuthentication>
authenticate(String username
processLdapUser(password, domainId, user, rc, ldapUser,
accountType);
} catch (NoLdapUserMatchingQueryException e) {
logger.debug(e.getMessage());
- // no user in ldap ==>> disable user in cloudstack
- disableUserInCloudStack(user);
+ if (e.getMessage().contains(LDAP_READ_TIMED_OUT_MESSAGE) &&
!rc.first()) {
+
rc.second(ActionOnFailedAuthentication.INCREMENT_INCORRECT_LOGIN_ATTEMPT_COUNT);
+ } else {
+ // no user in ldap ==>> disable user in cloudstack
+ disableUserInCloudStack(user);
+ }
Review Comment:
(Sorry I may not have pressed buttons correctly last time)
Can this be moved to a new method as it is being used twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
