CLOUDSTACK-6833 [Hyper-V] Volume snapshot creation returns success even though snapshots are not supported for Hyper-V
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/945e879b Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/945e879b Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/945e879b Branch: refs/heads/4.4-forward Commit: 945e879bf221454cd42f1e7ef0a46e9a4aa6a156 Parents: 025c143 Author: Rajesh Battala <[email protected]> Authored: Thu Jun 5 12:01:43 2014 +0530 Committer: Rajesh Battala <[email protected]> Committed: Thu Jun 5 15:06:24 2014 +0530 ---------------------------------------------------------------------- server/src/com/cloud/storage/VolumeApiServiceImpl.java | 3 +++ 1 file changed, 3 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/945e879b/server/src/com/cloud/storage/VolumeApiServiceImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/storage/VolumeApiServiceImpl.java b/server/src/com/cloud/storage/VolumeApiServiceImpl.java index 42d318c..6703e61 100644 --- a/server/src/com/cloud/storage/VolumeApiServiceImpl.java +++ b/server/src/com/cloud/storage/VolumeApiServiceImpl.java @@ -1662,6 +1662,9 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic if (volume.getInstanceId() != null) vm = _vmInstanceDao.findById(volume.getInstanceId()); + if (volume.getHypervisorType() == HypervisorType.Hyperv) { + throw new InvalidParameterValueException("Volume Snapshots are not supported on Hypervisor Type : Hyper-V"); + } if (vm != null) { // serialize VM operation AsyncJobExecutionContext jobContext = AsyncJobExecutionContext.getCurrentExecutionContext();
