Copilot commented on code in PR #11068:
URL: https://github.com/apache/cloudstack/pull/11068#discussion_r2232785758
##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1831,6 +1831,7 @@ public VMTemplateVO
createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
throw new InvalidParameterValueException("Failed to create private
template record, please specify only one of volume ID (" + volumeId +
") and snapshot ID (" + snapshotId + ")");
}
+ CPU.CPUArch arch = cmd.getArch();
Review Comment:
The arch variable could be null if cmd.getArch() returns null (when no
architecture is specified or an invalid one is provided). The subsequent usage
of this variable should handle the null case or provide a default value.
```suggestion
CPU.CPUArch arch = cmd.getArch();
if (arch == null) {
throw new InvalidParameterValueException("Architecture is not
specified or invalid. Please provide a valid architecture.");
}
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java:
##########
@@ -234,6 +240,10 @@ public String getAccountName() {
return accountName;
}
+ public CPU.CPUArch getArch() {
+ return CPU.CPUArch.fromType(arch);
Review Comment:
The method could return null if an invalid architecture string is provided,
but there's no null check or validation. This could cause a
NullPointerException in the calling code. Consider adding validation to ensure
only valid architectures are accepted.
```suggestion
CPU.CPUArch cpuArch = CPU.CPUArch.fromType(arch);
if (cpuArch == null) {
throw new InvalidParameterValueException("Invalid architecture
type: " + arch);
}
return cpuArch;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
