DaanHoogland commented on code in PR #11355:
URL: https://github.com/apache/cloudstack/pull/11355#discussion_r2244957691
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -920,7 +929,7 @@ private Pair<List<Long>, Integer>
searchForEventIdsAndCount(ListEventsCmd cmd) {
eventSearchBuilder.and("createDateB",
eventSearchBuilder.entity().getCreateDate(), SearchCriteria.Op.BETWEEN);
eventSearchBuilder.and("createDateG",
eventSearchBuilder.entity().getCreateDate(), SearchCriteria.Op.GTEQ);
eventSearchBuilder.and("createDateL",
eventSearchBuilder.entity().getCreateDate(), SearchCriteria.Op.LTEQ);
- eventSearchBuilder.and("state",
eventSearchBuilder.entity().getState(), SearchCriteria.Op.NEQ);
Review Comment:
hm, are we sure we never depend on a search for states except for…? It seems
strange just reversing the condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
