JoaoJandre commented on code in PR #11455:
URL: https://github.com/apache/cloudstack/pull/11455#discussion_r2282326067
##########
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java:
##########
@@ -1621,7 +1621,8 @@ public SnapshotInfo takeSnapshot(VolumeInfo volume)
throws ResourceAllocationExc
if (snapshotStrategy == null) {
_snapshotDao.remove(snapshotId);
logger.debug("No strategy found for creation of snapshot [{}],
removing its record from the database.", snapshot);
- throw new CloudRuntimeException(String.format("Can't find
snapshot strategy to deal with snapshot:%s", snapshot.getSnapshotVO()));
+ throw new UnsupportedOperationException(String.format("Unable
to find a snapshot strategy to create snapshot [%s] of volume [%s]. Please
check the logs.",
Review Comment:
@weizhouapache We currently have 5 snapshot strategies. This error is thrown
when no snapshot strategy supports the snapshot being taken. Thus, the message
cannot be specific to a single strategy.
Depending on the storage/strategy being used, it might be possible to
create volume snapshots and disk-only VM snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
