vishesh92 commented on code in PR #10212:
URL: https://github.com/apache/cloudstack/pull/10212#discussion_r2300292294
##########
server/src/main/java/com/cloud/vm/UserVmManager.java:
##########
@@ -59,6 +59,12 @@ public interface UserVmManager extends UserVmService {
"Destroys the VM's root volume when the VM is destroyed.",
true, ConfigKey.Scope.Domain);
+ ConfigKey<String> VmDistinctHostNameScope = new ConfigKey<>(String.class,
"vm.distinct.hostname.scope", ConfigKey.CATEGORY_ADVANCED,
+ "network",
+ "Scope of resources to check while checking if the hostname is
unique. Possible values are global, domain, subdomain, account, network.",
+ true, ConfigKey.Scope.Global, null, "VM distinct hostname scope",
null, null, null, ConfigKey.Kind.Select,
+ "global,domain,subdomain,account,network");
+
Review Comment:
For project, we specify account_id as the project id. So, this is covered by
the account scope. Adding project will make the check complicated.
For networks in a VPC, the network domain is same for all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
