rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2303239787
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java:
##########
@@ -67,130 +67,130 @@ public class CreateServiceOfferingCmd extends BaseCmd {
@Parameter(name = ApiConstants.DISPLAY_TEXT, type = CommandType.STRING,
description = "The display text of the service offering, defaults to 'name'.")
private String displayText;
- @Parameter(name = ApiConstants.PROVISIONINGTYPE, type =
CommandType.STRING, description = "provisioning type used to create volumes.
Valid values are thin, sparse, fat.")
+ @Parameter(name = ApiConstants.PROVISIONINGTYPE, type =
CommandType.STRING, description = "Provisioning type used to create volumes.
Valid values are thin, sparse, fat.")
private String provisioningType = Storage.ProvisioningType.THIN.toString();
- @Parameter(name = ApiConstants.MEMORY, type = CommandType.INTEGER,
required = false, description = "the total memory of the service offering in
MB")
+ @Parameter(name = ApiConstants.MEMORY, type = CommandType.INTEGER,
required = false, description = "The total memory of the service offering in
MB")
private Integer memory;
- @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required =
true, description = "the name of the service offering")
+ @Parameter(name = ApiConstants.NAME, type = CommandType.STRING, required =
true, description = "The name of the service offering")
private String serviceOfferingName;
- @Parameter(name = ApiConstants.OFFER_HA, type = CommandType.BOOLEAN,
description = "the HA for the service offering")
+ @Parameter(name = ApiConstants.OFFER_HA, type = CommandType.BOOLEAN,
description = "The HA for the service offering")
private Boolean offerHa;
- @Parameter(name = ApiConstants.LIMIT_CPU_USE, type = CommandType.BOOLEAN,
description = "restrict the CPU usage to committed service offering")
+ @Parameter(name = ApiConstants.LIMIT_CPU_USE, type = CommandType.BOOLEAN,
description = "Restrict the CPU usage to committed service offering")
private Boolean limitCpuUse;
@Parameter(name = ApiConstants.IS_VOLATILE,
type = CommandType.BOOLEAN,
- description = "true if the virtual machine needs to be volatile so
that on every reboot of VM, original root disk is dettached then destroyed and
a fresh root disk is created and attached to VM")
+ description = "True if the Instance needs to be volatile so that
on every reboot, the original root disk is detached, then destroyed and a fresh
root disk is created and attached to the Instance")
private Boolean isVolatile;
- @Parameter(name = ApiConstants.STORAGE_TYPE, type = CommandType.STRING,
description = "the storage type of the service offering. Values are local and
shared.")
+ @Parameter(name = ApiConstants.STORAGE_TYPE, type = CommandType.STRING,
description = "The storage type of the service offering. Values are local and
shared.")
private String storageType;
- @Parameter(name = ApiConstants.TAGS, type = CommandType.STRING,
description = "the tags for this service offering.")
+ @Parameter(name = ApiConstants.TAGS, type = CommandType.STRING,
description = "The tags for this service offering.")
private String tags;
@Parameter(name = ApiConstants.DOMAIN_ID,
type = CommandType.LIST,
collectionType = CommandType.UUID,
entityType = DomainResponse.class,
- description = "the ID of the containing domain(s), null for public
offerings")
+ description = "The ID of the containing domain(s), null for public
offerings")
private List<Long> domainIds;
@Parameter(name = ApiConstants.ZONE_ID,
type = CommandType.LIST,
collectionType = CommandType.UUID,
entityType = ZoneResponse.class,
- description = "the ID of the containing zone(s), null for public
offerings",
+ description = "The ID of the containing zone(s), null for public
offerings",
since = "4.13")
private List<Long> zoneIds;
- @Parameter(name = ApiConstants.HOST_TAGS, type = CommandType.STRING,
description = "the host tag for this service offering.")
+ @Parameter(name = ApiConstants.HOST_TAGS, type = CommandType.STRING,
description = "The host tag for this service offering.")
private String hostTag;
- @Parameter(name = ApiConstants.IS_SYSTEM_OFFERING, type =
CommandType.BOOLEAN, description = "is this a system vm offering")
+ @Parameter(name = ApiConstants.IS_SYSTEM_OFFERING, type =
CommandType.BOOLEAN, description = "Is this a system vm offering")
private Boolean isSystem;
@Parameter(name = ApiConstants.SYSTEM_VM_TYPE,
type = CommandType.STRING,
- description = "the system VM type. Possible types are
\"domainrouter\", \"consoleproxy\" and \"secondarystoragevm\".")
+ description = "The system VM type. Possible types are
\"domainrouter\", \"consoleproxy\" and \"secondarystoragevm\".")
private String systemVmType;
@Parameter(name = ApiConstants.NETWORKRATE,
type = CommandType.INTEGER,
- description = "data transfer rate in megabits per second allowed.
Supported only for non-System offering and system offerings having
\"domainrouter\" systemvmtype")
+ description = "Data transfer rate in megabits per second allowed.
Supported only for non-System offering and system offerings having
\"domainrouter\" systemvmtype")
private Integer networkRate;
@Parameter(name = ApiConstants.DEPLOYMENT_PLANNER,
type = CommandType.STRING,
- description = "The deployment planner heuristics used to deploy a
VM of this offering. If null, value of global config vm.deployment.planner is
used")
+ description = "The deployment planner heuristics used to deploy an
Instance of this offering. If null, value of global config
vm.deployment.planner is used")
private String deploymentPlanner;
- @Parameter(name = ApiConstants.SERVICE_OFFERING_DETAILS, type =
CommandType.MAP, description = "details for planner, used to store specific
parameters")
+ @Parameter(name = ApiConstants.SERVICE_OFFERING_DETAILS, type =
CommandType.MAP, description = "Details for planner, used to store specific
parameters")
private Map details;
- @Parameter(name = ApiConstants.ROOT_DISK_SIZE, type = CommandType.LONG,
since = "4.15", description = "the Root disk size in GB.")
+ @Parameter(name = ApiConstants.ROOT_DISK_SIZE, type = CommandType.LONG,
since = "4.15", description = "The Root disk size in GB.")
private Long rootDiskSize;
- @Parameter(name = ApiConstants.BYTES_READ_RATE, type = CommandType.LONG,
required = false, description = "bytes read rate of the disk offering")
+ @Parameter(name = ApiConstants.BYTES_READ_RATE, type = CommandType.LONG,
required = false, description = "Bytes read rate of the disk offering")
private Long bytesReadRate;
- @Parameter(name = ApiConstants.BYTES_READ_RATE_MAX, type =
CommandType.LONG, required = false, description = "burst bytes read rate of the
disk offering")
+ @Parameter(name = ApiConstants.BYTES_READ_RATE_MAX, type =
CommandType.LONG, required = false, description = "Burst bytes read rate of the
disk offering")
private Long bytesReadRateMax;
- @Parameter(name = ApiConstants.BYTES_READ_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "length (in seconds) of the
burst")
+ @Parameter(name = ApiConstants.BYTES_READ_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "Length (in seconds) of the
burst")
private Long bytesReadRateMaxLength;
- @Parameter(name = ApiConstants.BYTES_WRITE_RATE, type = CommandType.LONG,
required = false, description = "bytes write rate of the disk offering")
+ @Parameter(name = ApiConstants.BYTES_WRITE_RATE, type = CommandType.LONG,
required = false, description = "Bytes write rate of the disk offering")
private Long bytesWriteRate;
- @Parameter(name = ApiConstants.BYTES_WRITE_RATE_MAX, type =
CommandType.LONG, required = false, description = "burst bytes write rate of
the disk offering")
+ @Parameter(name = ApiConstants.BYTES_WRITE_RATE_MAX, type =
CommandType.LONG, required = false, description = "Burst bytes write rate of
the disk offering")
private Long bytesWriteRateMax;
- @Parameter(name = ApiConstants.BYTES_WRITE_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "length (in seconds) of the
burst")
+ @Parameter(name = ApiConstants.BYTES_WRITE_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "Length (in seconds) of the
burst")
private Long bytesWriteRateMaxLength;
- @Parameter(name = ApiConstants.IOPS_READ_RATE, type = CommandType.LONG,
required = false, description = "io requests read rate of the disk offering")
+ @Parameter(name = ApiConstants.IOPS_READ_RATE, type = CommandType.LONG,
required = false, description = "I/O requests read rate of the disk offering")
private Long iopsReadRate;
- @Parameter(name = ApiConstants.IOPS_READ_RATE_MAX, type =
CommandType.LONG, required = false, description = "burst requests read rate of
the disk offering")
+ @Parameter(name = ApiConstants.IOPS_READ_RATE_MAX, type =
CommandType.LONG, required = false, description = "Burst requests read rate of
the disk offering")
private Long iopsReadRateMax;
- @Parameter(name = ApiConstants.IOPS_READ_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "length (in seconds) of the
burst")
+ @Parameter(name = ApiConstants.IOPS_READ_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "Length (in seconds) of the
burst")
private Long iopsReadRateMaxLength;
- @Parameter(name = ApiConstants.IOPS_WRITE_RATE, type = CommandType.LONG,
required = false, description = "io requests write rate of the disk offering")
+ @Parameter(name = ApiConstants.IOPS_WRITE_RATE, type = CommandType.LONG,
required = false, description = "I/O requests write rate of the disk offering")
private Long iopsWriteRate;
- @Parameter(name = ApiConstants.IOPS_WRITE_RATE_MAX, type =
CommandType.LONG, required = false, description = "burst io requests write rate
of the disk offering")
+ @Parameter(name = ApiConstants.IOPS_WRITE_RATE_MAX, type =
CommandType.LONG, required = false, description = "Burst io requests write rate
of the disk offering")
private Long iopsWriteRateMax;
- @Parameter(name = ApiConstants.IOPS_WRITE_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "length (in seconds) of the
burst")
+ @Parameter(name = ApiConstants.IOPS_WRITE_RATE_MAX_LENGTH, type =
CommandType.LONG, required = false, description = "Length (in seconds) of the
burst")
private Long iopsWriteRateMaxLength;
- @Parameter(name = ApiConstants.CUSTOMIZED_IOPS, type =
CommandType.BOOLEAN, required = false, description = "whether compute offering
iops is custom or not", since = "4.4")
+ @Parameter(name = ApiConstants.CUSTOMIZED_IOPS, type =
CommandType.BOOLEAN, required = false, description = "Whether compute offering
iops is custom or not", since = "4.4")
private Boolean customizedIops;
- @Parameter(name = ApiConstants.MIN_IOPS, type = CommandType.LONG, required
= false, description = "min iops of the compute offering", since = "4.4")
+ @Parameter(name = ApiConstants.MIN_IOPS, type = CommandType.LONG, required
= false, description = "Min iops of the compute offering", since = "4.4")
Review Comment:
iops -> IOPS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
