rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2309264745
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/CreateVlanIpRangeCmd.java:
##########
@@ -53,66 +53,66 @@ public class CreateVlanIpRangeCmd extends BaseCmd {
@Parameter(name = ApiConstants.ACCOUNT,
type = CommandType.STRING,
- description = "account who will own the VLAN. If VLAN is Zone
wide, this parameter should be omitted")
+ description = "Account who will own the VLAN. If VLAN is Zone
wide, this parameter should be omitted")
private String accountName;
@Parameter(name = ApiConstants.PROJECT_ID,
type = CommandType.UUID,
entityType = ProjectResponse.class,
- description = "project who will own the VLAN. If VLAN is Zone
wide, this parameter should be omitted")
+ description = "Project who will own the VLAN. If VLAN is Zone
wide, this parameter should be omitted")
private Long projectId;
- @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
entityType = DomainResponse.class, description = "domain ID of the account
owning a VLAN")
+ @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
entityType = DomainResponse.class, description = "Domain ID of the Account
owning a VLAN")
private Long domainId;
- @Parameter(name = ApiConstants.END_IP, type = CommandType.STRING,
description = "the ending IP address in the VLAN IP range")
+ @Parameter(name = ApiConstants.END_IP, type = CommandType.STRING,
description = "The ending IP address in the VLAN IP range")
private String endIp;
- @Parameter(name = ApiConstants.FOR_VIRTUAL_NETWORK, type =
CommandType.BOOLEAN, description = "true if VLAN is of Virtual type, false if
Direct")
+ @Parameter(name = ApiConstants.FOR_VIRTUAL_NETWORK, type =
CommandType.BOOLEAN, description = "True if VLAN is of Virtual type, false if
Direct")
private Boolean forVirtualNetwork;
- @Parameter(name = ApiConstants.GATEWAY, type = CommandType.STRING,
description = "the gateway of the VLAN IP range")
+ @Parameter(name = ApiConstants.GATEWAY, type = CommandType.STRING,
description = "The gateway of the VLAN IP range")
private String gateway;
- @Parameter(name = ApiConstants.NETMASK, type = CommandType.STRING,
description = "the netmask of the VLAN IP range")
+ @Parameter(name = ApiConstants.NETMASK, type = CommandType.STRING,
description = "The netmask of the VLAN IP range")
private String netmask;
@Parameter(name = ApiConstants.POD_ID,
type = CommandType.UUID,
entityType = PodResponse.class,
- description = "optional parameter. Have to be specified for
Direct Untagged vlan only.")
+ description = "Optional parameter. Have to be specified for
Direct Untagged vlan only.")
private Long podId;
- @Parameter(name = ApiConstants.START_IP, type = CommandType.STRING,
description = "the beginning IP address in the VLAN IP range")
+ @Parameter(name = ApiConstants.START_IP, type = CommandType.STRING,
description = "The beginning IP address in the VLAN IP range")
private String startIp;
- @Parameter(name = ApiConstants.VLAN, type = CommandType.STRING,
description = "the ID or VID of the VLAN. If not specified,"
+ @Parameter(name = ApiConstants.VLAN, type = CommandType.STRING,
description = "The ID or VID of the VLAN. If not specified,"
+ " will be defaulted to the vlan of the network or if vlan of the
network is null - to Untagged")
private String vlan;
- @Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID,
entityType = ZoneResponse.class, description = "the Zone ID of the VLAN IP
range")
+ @Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID,
entityType = ZoneResponse.class, description = "The Zone ID of the VLAN IP
range")
private Long zoneId;
- @Parameter(name = ApiConstants.NETWORK_ID, type = CommandType.UUID,
entityType = NetworkResponse.class, description = "the network id")
+ @Parameter(name = ApiConstants.NETWORK_ID, type = CommandType.UUID,
entityType = NetworkResponse.class, description = "The network id")
Review Comment:
'ID'
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/CreateVlanIpRangeCmd.java:
##########
@@ -53,66 +53,66 @@ public class CreateVlanIpRangeCmd extends BaseCmd {
@Parameter(name = ApiConstants.ACCOUNT,
type = CommandType.STRING,
- description = "account who will own the VLAN. If VLAN is Zone
wide, this parameter should be omitted")
+ description = "Account who will own the VLAN. If VLAN is Zone
wide, this parameter should be omitted")
private String accountName;
@Parameter(name = ApiConstants.PROJECT_ID,
type = CommandType.UUID,
entityType = ProjectResponse.class,
- description = "project who will own the VLAN. If VLAN is Zone
wide, this parameter should be omitted")
+ description = "Project who will own the VLAN. If VLAN is Zone
wide, this parameter should be omitted")
private Long projectId;
- @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
entityType = DomainResponse.class, description = "domain ID of the account
owning a VLAN")
+ @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
entityType = DomainResponse.class, description = "Domain ID of the Account
owning a VLAN")
private Long domainId;
- @Parameter(name = ApiConstants.END_IP, type = CommandType.STRING,
description = "the ending IP address in the VLAN IP range")
+ @Parameter(name = ApiConstants.END_IP, type = CommandType.STRING,
description = "The ending IP address in the VLAN IP range")
private String endIp;
- @Parameter(name = ApiConstants.FOR_VIRTUAL_NETWORK, type =
CommandType.BOOLEAN, description = "true if VLAN is of Virtual type, false if
Direct")
+ @Parameter(name = ApiConstants.FOR_VIRTUAL_NETWORK, type =
CommandType.BOOLEAN, description = "True if VLAN is of Virtual type, false if
Direct")
private Boolean forVirtualNetwork;
- @Parameter(name = ApiConstants.GATEWAY, type = CommandType.STRING,
description = "the gateway of the VLAN IP range")
+ @Parameter(name = ApiConstants.GATEWAY, type = CommandType.STRING,
description = "The gateway of the VLAN IP range")
private String gateway;
- @Parameter(name = ApiConstants.NETMASK, type = CommandType.STRING,
description = "the netmask of the VLAN IP range")
+ @Parameter(name = ApiConstants.NETMASK, type = CommandType.STRING,
description = "The netmask of the VLAN IP range")
private String netmask;
@Parameter(name = ApiConstants.POD_ID,
type = CommandType.UUID,
entityType = PodResponse.class,
- description = "optional parameter. Have to be specified for
Direct Untagged vlan only.")
+ description = "Optional parameter. Have to be specified for
Direct Untagged vlan only.")
private Long podId;
- @Parameter(name = ApiConstants.START_IP, type = CommandType.STRING,
description = "the beginning IP address in the VLAN IP range")
+ @Parameter(name = ApiConstants.START_IP, type = CommandType.STRING,
description = "The beginning IP address in the VLAN IP range")
private String startIp;
- @Parameter(name = ApiConstants.VLAN, type = CommandType.STRING,
description = "the ID or VID of the VLAN. If not specified,"
+ @Parameter(name = ApiConstants.VLAN, type = CommandType.STRING,
description = "The ID or VID of the VLAN. If not specified,"
+ " will be defaulted to the vlan of the network or if vlan of the
network is null - to Untagged")
private String vlan;
- @Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID,
entityType = ZoneResponse.class, description = "the Zone ID of the VLAN IP
range")
+ @Parameter(name = ApiConstants.ZONE_ID, type = CommandType.UUID,
entityType = ZoneResponse.class, description = "The Zone ID of the VLAN IP
range")
private Long zoneId;
- @Parameter(name = ApiConstants.NETWORK_ID, type = CommandType.UUID,
entityType = NetworkResponse.class, description = "the network id")
+ @Parameter(name = ApiConstants.NETWORK_ID, type = CommandType.UUID,
entityType = NetworkResponse.class, description = "The network id")
private Long networkID;
- @Parameter(name = ApiConstants.PHYSICAL_NETWORK_ID, type =
CommandType.UUID, entityType = PhysicalNetworkResponse.class, description =
"the physical network id")
+ @Parameter(name = ApiConstants.PHYSICAL_NETWORK_ID, type =
CommandType.UUID, entityType = PhysicalNetworkResponse.class, description =
"The physical network id")
Review Comment:
'ID'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
