shwstppr commented on code in PR #10862:
URL: https://github.com/apache/cloudstack/pull/10862#discussion_r2318819566
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java:
##########
@@ -118,7 +122,9 @@ private KubernetesSupportedVersionResponse
createKubernetesSupportedVersionRespo
response.setSupportsHA(compareSemanticVersions(kubernetesSupportedVersion.getSemanticVersion(),
KubernetesClusterService.MIN_KUBERNETES_VERSION_HA_SUPPORT)>=0);
response.setSupportsAutoscaling(versionSupportsAutoscaling(kubernetesSupportedVersion));
-
updateTemplateDetailsInKubernetesSupportedVersionResponse(kubernetesSupportedVersion,
response);
+ Account caller = CallContext.current().getCallingAccount();
+ boolean isRootAdmin = accountManager.isRootAdmin(caller.getId());
Review Comment:
@vits-hugs sorry if I'm not getting it but I think we are still checking
isRootAdmin for each version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
