sureshanaparti commented on code in PR #11637:
URL: https://github.com/apache/cloudstack/pull/11637#discussion_r2348624668
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -1499,6 +1502,14 @@ protected String[] createUserApiKeyAndSecretKey(long
userId) {
}
}
+ protected String generateRandomUserPassword(Long domainId) {
+ Integer passwordPolicyMinimumLength =
PasswordPolicy.PasswordPolicyMinimumLength.valueIn(domainId);
+ if (passwordPolicyMinimumLength == null || passwordPolicyMinimumLength
< CKS_USER_MIN_PASSWORD_LENGTH) {
+ passwordPolicyMinimumLength = CKS_USER_MIN_PASSWORD_LENGTH;
Review Comment:
operator doesn't know that the min length is implicitly set here if it's
configured between 1 and 11. Update the config description that min 12 length
is considered for CKS users, or better we restrict the min length to be >= 12
for all (to be strong for all cases).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
