weizhouapache commented on PR #11652: URL: https://github.com/apache/cloudstack/pull/11652#issuecomment-3302448555
> > Is this an issue with main branch only ? @harikrishna-patnala > > > > The smoke tests result of the PR #11598 looks good. > > > > Can you test scaling cks cluster with the same offering ? > > main and 4.21. I think this happened as part of forward merging 4.20 to main. 4.20 does not have this [loop](https://github.com/shapeblue/cloudstack/blob/2d1e058d24aabf961dd254032f3a4ad4e464330d/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterScaleWorker.java#L551), so return statement is working there. Thanks @harikrishna-patnala makes sense Maybe we can remove the lines and add state transitions in case nothing happens if offering is same as before. Stopped -> OperationSucceeded -> Stopped and for Running state too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
