rohityadavcloud commented on code in PR #2:
URL:
https://github.com/apache/cloudstack-installer/pull/2#discussion_r2362124801
##########
install.sh:
##########
@@ -138,10 +139,14 @@ EOF
configure_repo() {
info "Configuring CloudStack $CS_VERSION repo"
+ NAME=$(sed -rn 's|^deb\s+\S+\s+(\w+)\s+main.*$|\1|p' /etc/apt/sources.list |
head -n 1)
+
mkdir -p /etc/apt/keyrings
+ wget -O - https://download.cloudstack.org/release.asc | sudo tee
/etc/apt/trusted.gpg.d/cloudstack.asc
Review Comment:
duplicate here?
##########
README.md:
##########
@@ -8,13 +8,13 @@ NOTE: Work in progress
To install and deploy [CloudStack](https://cloudstack.apache.org), just copy
and run the following as `root` user:
```bash
-curl -sL https://c8k.in/stall.sh | bash
+curl -sL
https://raw.githubusercontent.com/Bitsonwheels/cloudstack-installer/refs/heads/main/install.sh
| bash
Review Comment:
Can't hardcode to this repo
##########
README.md:
##########
@@ -8,13 +8,13 @@ NOTE: Work in progress
To install and deploy [CloudStack](https://cloudstack.apache.org), just copy
and run the following as `root` user:
```bash
-curl -sL https://c8k.in/stall.sh | bash
+curl -sL
https://raw.githubusercontent.com/Bitsonwheels/cloudstack-installer/refs/heads/main/install.sh
| bash
```
Here's how you should really run it though:
```bash
-curl -o install.sh https://c8k.in/stall.sh
+curl -o install.sh
https://raw.githubusercontent.com/Bitsonwheels/cloudstack-installer/refs/heads/main/install.sh
Review Comment:
Can't hardcode to this repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
