Copilot commented on code in PR #11654:
URL: https://github.com/apache/cloudstack/pull/11654#discussion_r2355018085
##########
tools/appliance/systemvmtemplate/scripts/configure_systemvm_services.sh:
##########
@@ -132,15 +132,41 @@ function configure_services() {
# Disable container services
systemctl disable containerd
- # Disable cloud init by default
-cat <<EOF > /etc/cloud/cloud.cfg.d/cloudstack.cfg
-datasource_list: ['CloudStack']
-datasource:
- CloudStack:
- max_wait: 120
- timeout: 50
+
+ cat <<EOF > /etc/cloud/cloud.cfg.d/cloudstack.cfg
+#cloud-config
+datasource_list: ['NoCloud']
+network:
+ config: disabled
+manage_etc_hosts: false
+manage_resolv_conf: false
+users: []
+disable_root: false
+ssh_pwauth: false
+cloud_init_modules:
+ - migrator
+ - seed_random
+ - bootcmd
+ - write-files
+ - growpart
+ - resizefs
+ - disk_setup
+ - mounts
+ - rsyslog
+cloud_config_modules:
+ - locale
+ - timezone
+ - runcmd
+cloud_final_modules:
+ - scripts-per-once
+ - scripts-per-boot
+ - scripts-per-instance
+ - scripts-user
+ - final-message
+ - power-state-change
Review Comment:
The indentation in the cloud-init configuration is inconsistent. Lines
147-155 use single space indentation while lines 157-166 use single space
indentation as well, but the YAML structure should use consistent 2-space
indentation for proper formatting.
```suggestion
- migrator
- seed_random
- bootcmd
- write-files
- growpart
- resizefs
- disk_setup
- mounts
- rsyslog
cloud_config_modules:
- locale
- timezone
- runcmd
cloud_final_modules:
- scripts-per-once
- scripts-per-boot
- scripts-per-instance
- scripts-user
- final-message
- power-state-change
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
