shwstppr commented on code in PR #11719:
URL: https://github.com/apache/cloudstack/pull/11719#discussion_r2381030300
##########
ui/src/views/compute/EditVM.vue:
##########
@@ -164,7 +170,8 @@ export default {
groups: {
loading: false,
opts: []
- }
+ },
+ extraConfigEnabled: this.$store.getters.features.additionalconfigenabled
Review Comment:
curious - why a computed variable in DeployVM and a data variable here?
##########
api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java:
##########
@@ -140,6 +140,10 @@ public class CapabilitiesResponse extends BaseResponse {
@Param(description = "true if dynamically scaling for instances is
enabled", since = "4.21.0")
private Boolean dynamicScalingEnabled;
+ @SerializedName(ApiConstants.ADDITONAL_CONFIG_ENABLED)
+ @Param(description = "true if additional configurations or extraconfig can
be passed to Instances", since = "4.20.2")
Review Comment:
Not related to this PR but as some point we should start using a generic Map
response or some other means. Adding a new response param for a new global
setting value is an unnecessary hassle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
