slavkap commented on code in PR #11773:
URL: https://github.com/apache/cloudstack/pull/11773#discussion_r2412904090
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -2688,7 +2688,8 @@ private void
handleRemoveChildStoragePoolFromDatastoreCluster(Set<String> childD
}
- private void updateStoragePoolHostVOAndBytes(StoragePool pool, long
hostId, ModifyStoragePoolAnswer mspAnswer) {
+ @Override
+ public void updateStoragePoolHostVOAndBytes(StoragePool pool, long hostId,
ModifyStoragePoolAnswer mspAnswer) {
Review Comment:
@weizhouapache, is it possible to add the condition if the pool is StorPool
to not set the capacity/used bytes? We have a custom ModifyStorageCommand and
this one returns wrong values for us. The correct ones will be applied when the
storage stats are collected and meanwhile this could cause issues for the
StorPool users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
