weizhouapache commented on PR #11773:
URL: https://github.com/apache/cloudstack/pull/11773#issuecomment-3365016293
> I can not see whether this would fix the issue. It probably would and
testing must show.
yes, this needs testing.
actually in the life cycle of other storage pool, the logic is the same,
which I think makes sense:
```
dataStoreHelper.cancelMaintain(store);
storagePoolAutmation.cancelMaintain(store);
```
except `CloudStackPrimaryDataStoreLifeCycleImpl`, I have no idea why
> But in general the cancel maintenance method is 130 lines and three
phases, two of which should be structured and modularised more to be easier to
read and control, what they do.
+1, please go ahead with the refactoring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
