Copilot commented on code in PR #11571:
URL: https://github.com/apache/cloudstack/pull/11571#discussion_r2418824046
##########
ui/src/views/setting/ConfigurationValue.vue:
##########
@@ -280,6 +295,9 @@ export default {
name: configrecord.name,
value: newValue
}
+ if (this.scopeKey === 'domainid' && !params[this.scopeKey]) {
Review Comment:
The condition `!params[this.scopeKey]` will be true for falsy values
including 0, which could be a valid domain ID. This should use a more specific
check like `params[this.scopeKey] == null` to only check for null/undefined
values.
```suggestion
if (this.scopeKey === 'domainid' && params[this.scopeKey] == null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
