Re: [PR] ui: Allow edit source CIDR on load balancer rule [cloudstack]

[via GitHub]

CodeBleu commented on PR #11766:
URL: https://github.com/apache/cloudstack/pull/11766#issuecomment-3385880357

   > > > I created packages [#11766 
(comment)](https://github.com/apache/cloudstack/pull/11766#issuecomment-3379669157),
 which is based on this PR merged in main. It should contain all the code.
   > > 
   > > 
   > > Could it not be including the code because it's in the code to use 
[4.22](https://github.com/apache/cloudstack/pull/11568/commits/316036b0814b1160e9d3ae7b1572936c80e8b452),
 and the packaging is not including it? I'm not sure exactly how that works. I 
just manually built it from the main branch locally and used that to test with.
   > > I'm just not able to reproduce your issue, so it's hard for me to do 
anything differently if it's working for me.
   > 
   > I understand, but the packeging job creates a merge commit and builds from 
that.
   > 
   > > If you let me know the steps you are taking, I can try to reproduce. How 
does one get the package from the package build ? [#11766 
(comment)](https://github.com/apache/cloudstack/pull/11766#issuecomment-3379669157)
   > 
   > So I build a clean set of packages from this PR merged into main (the 
standard at blueorangutan package) and then I build a virtualised environment 
from that. I tried several formats. As the last one exactly the one you show in 
your clip; I first made it empty (that was successful) and then I added two 
cidrs back in. I tried with “1.1.1.1/32,2.2.2.0/24” and with 
“1.2.3.4/32,5.6.7.8/32”. Both failed to add. When finally I add a single cidr 
it succeeds (e.g. “1.2.3.0/24”)
   > 
   > Are you sure you don’t have an extra fix (in comparison to main) in your 
environment?
   > 
   > <img alt="Screenshot 2025-10-09 at 09 05 49" width="1265" height="530" 
src="https://private-user-images.githubusercontent.com/2486961/499211873-dc2054b7-6c40-4582-8a2d-32ce1dbd64d6.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjAwMTY0NzUsIm5iZiI6MTc2MDAxNjE3NSwicGF0aCI6Ii8yNDg2OTYxLzQ5OTIxMTg3My1kYzIwNTRiNy02YzQwLTQ1ODItOGEyZC0zMmNlMWRiZDY0ZDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTAwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTEwMDlUMTMyMjU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjdlNDY0NmRkODljMTMwMzJlNjBlZDcwNjliMjM3YzA1ZDdlOWEzZWY4NDBhN2U0NGVjZmNjNGY5M2E3MThjMCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.7i_FRk9fM-6N91dMzcibq55CYy0NX0osVSv0g8_FqQY";>
 <img alt="Screenshot 2025-10-09 at 09 06 26" width="444" height="379" 
src="https://private-user-images.githubusercontent.com/2486961/49921
 
1901-16e084f9-2c17-4f0d-9528-ba1d5154eff1.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjAwMTY0NzUsIm5iZiI6MTc2MDAxNjE3NSwicGF0aCI6Ii8yNDg2OTYxLzQ5OTIxMTkwMS0xNmUwODRmOS0yYzE3LTRmMGQtOTUyOC1iYTFkNTE1NGVmZjEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTAwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTEwMDlUMTMyMjU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjdkZmFkMjBhOGU3ZjZlMTAxMzU0YWQ5YzkwZjE1ZTJjNmQ5MjY4NzYzOGY4ZTU3ZTc4ZDgwMDA2MmYwYmY4OSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.1PZiwfyyg5MOlpKsiTDbyucR5zuq1_bxjQb9y-FMYoo">
 <img alt="Screenshot 2025-10-09 at 09 07 57" width="337" height="347" 
src="https://private-user-images.githubusercontent.com/2486961/499211926-b106c27a-ae91-43af-9278-8bccc16d9c44.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJj
 
b250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjAwMTY0NzUsIm5iZiI6MTc2MDAxNjE3NSwicGF0aCI6Ii8yNDg2OTYxLzQ5OTIxMTkyNi1iMTA2YzI3YS1hZTkxLTQzYWYtOTI3OC04YmNjYzE2ZDljNDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTAwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTEwMDlUMTMyMjU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NWVkNWYwMTU4YmJiZmIxOGM0YjhhYTJjMjNjZThjYzliYWFiNTg3NWZjOTdkYTk3MWY2Y2FiOGRlZDBmYmZiZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.9uVPDGfbK1mOgDuJSq15YcHeWKyCpkxn9R1LU8PQp1s">
   
   That particular issue in your screenshots is the space.
   <img width="699" height="622" alt="image" 
src="https://github.com/user-attachments/assets/41996290-74fb-47e2-96ea-834e0608b4e4";
 />
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org