DaanHoogland commented on PR #11636: URL: https://github.com/apache/cloudstack/pull/11636#issuecomment-3396176168
> > > oh, I did not notice where the values come from. > > > I think `LdapConfiguration.java` considers the domain level configurations, does it ? > > > > > > Yes initially if a domain is given, but with considering override of course. If no domain is passed global is considered. > > I am trying to understand what the problem is. > > If domain setting is blank or empty, it will be used, but this PR considers it as null. Is it what you expected ? or, should the global setting be considered ? I just re-tested it; - on domain level set a value for `ldap.search.group.principle` - check in the DB domain-settings table that it is set - set the setting for this domain to “” - in the DB it will be an empty string - reset the domain level setting - in the DB the record is gone So my question is, is this the behaivure we want - in domain an empty string is just an empty string - globally an empty string leads to a NULL in the DB cc @scottsignal I think an empty string should be an empty string. We could put a validation of sorts in place but introducing this inconsistency is not desirable imnsho. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
