DaanHoogland commented on PR #11636: URL: https://github.com/apache/cloudstack/pull/11636#issuecomment-3391299005
> > > > It works for the global setting @weizhouapache , but not for the domain level setting, @weizhouapache . You think we should do that as well? > > > > > > > > > @DaanHoogland I guess you mean we change the way of getting values ? > > > ``` > > > domain or zone value (if domain value is null) > > > ===> > > > domain or zone value (if domain value is null or blank) > > > ``` > > > > No I mean if I empty a domain value it still gets “” instead of null. (as a global value does) i.e. your change only applies on the global level. > > oh, I did not notice where the values come from. > I think `LdapConfiguration.java` considers the domain level configurations, does it ? Yes initially if a domain is given, but with considering override of course. If no domain is passed global is considered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
