Copilot commented on code in PR #11589:
URL: https://github.com/apache/cloudstack/pull/11589#discussion_r2413743156
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -530,6 +530,15 @@ public class ApiResponseHelper implements
ResponseGenerator {
@Inject
ResourceIconManager resourceIconManager;
+ public static String getPrettyDomainPath(String path) {
+ if (path == null) {
+ return null;
+ }
+ StringBuilder domainPath = new StringBuilder("ROOT");
+ (domainPath.append(path)).deleteCharAt(domainPath.length() - 1);
Review Comment:
The method assumes `path` always ends with a character that can be deleted,
but if `path` is empty or doesn't end with a trailing character,
`deleteCharAt(domainPath.length() - 1)` will throw a
StringIndexOutOfBoundsException.
```suggestion
if (path != null && !path.isEmpty()) {
domainPath.append(path);
// Remove trailing '/' if present
if (domainPath.length() > 0 &&
domainPath.charAt(domainPath.length() - 1) == '/') {
domainPath.deleteCharAt(domainPath.length() - 1);
}
}
```
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -3105,10 +3065,22 @@ private void populateAccount(ControlledEntityResponse
response, long accountId)
private void populateDomain(ControlledEntityResponse response, long
domainId) {
Domain domain = ApiDBUtils.findDomainById(domainId);
+ if (domain == null) {
+ return;
+ }
+ response.setDomainId(domain.getUuid());
+ response.setDomainName(domain.getName());
+ response.setDomainPath(getPrettyDomainPath(domain.getPath()));
+ }
+ private static void populateDomain(ControlledViewEntityResponse response,
long domainId) {
Review Comment:
This method is declared as `private static` but needs to be accessible from
other classes. It should be `public static` to match the usage pattern of other
helper methods in this class.
```suggestion
public static void populateDomain(ControlledViewEntityResponse response,
long domainId) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
