shwstppr commented on code in PR #11822:
URL: https://github.com/apache/cloudstack/pull/11822#discussion_r2419188325
##########
agent/src/main/java/com/cloud/agent/Agent.java:
##########
@@ -598,9 +597,9 @@ protected void setupStartupCommand(final StartupCommand
startup) {
}
protected String getAgentArch() {
- final Script command = new Script("/usr/bin/arch", 500, logger);
- final OutputInterpreter.OneLineParser parser = new
OutputInterpreter.OneLineParser();
- return command.execute(parser);
+ String arch =
Script.runSimpleBashScript(Script.getExecutableAbsolutePath("arch"), 2000);
Review Comment:
original PR had timeout as 1000 (base on my tests with OL8 x86_64
https://github.com/apache/cloudstack/issues/11251#issuecomment-3102503045),
this has 2000. Is there a new finding? Would it make sense to make this
configurable then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
